Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the <ref> processing again #156

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix the <ref> processing again #156

merged 1 commit into from
Aug 8, 2023

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 8, 2023

The string/rope semantics continue to bite us. The original fix in bd1cd44 was not correct, for unclear reasons. This version uses ExtractAll() to ensure we get a fresh CutRope that we can AppendDestructively() to Scratch, which is more in line with what other parts of the file do.

The string/rope semantics continue to bite us. The original fix in bd1cd44 was not correct, for unclear reasons. This version uses ExtractAll() to ensure we get a fresh CutRope that we can AppendDestructively() to Scratch, which is more in line with what other parts of the file do.
@domenic domenic merged commit 3b11b2d into main Aug 8, 2023
1 check passed
@domenic domenic deleted the fix-refs-again branch August 8, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant