New thematic for starting or expanding a family. #2465
Conversation
|
@BrahimMahadi can you review and test? Each thematic and experimentation must be independent from each other. This impact the following existing project, and some additional change might be required according to their implementation plan.
|
|
Note: It can't be "th-journeylab" because that don't represent a thematic but represent a product specific. |
Noted. That being said, it would be a bit of a moot point if you would like the thematics to be completely separate. This folder contains the SCSS called by Empathy and "Vitality". It's not really a thematic by itself per say. |
| @include journeyButtons($themeName, $themePrimaryColor, $themeSecondaryColor); | ||
|
|
||
| .#{$themeName} { | ||
| @include journeyComponents($themeName, #themePrimaryColor, #themeSecondaryColor); |
There was a problem hiding this comment.
Should the line be the following instead? Because it throws an error: @include journeyComponents($themeName, $themePrimaryColor, $themeSecondaryColor);
| @include journeyButtons($themeName, $themePrimaryColor, $themeSecondaryColor); | ||
|
|
||
| .#{$themeName} { | ||
| @include journeyComponents($themeName, #themePrimaryColor, #themeSecondaryColor); |
There was a problem hiding this comment.
Should the line be the following instead? Because it throws an error: @include journeyComponents($themeName, $themePrimaryColor, $themeSecondaryColor);
There was a problem hiding this comment.
That's correct, sorry for the error.
| title: Vitality theme | ||
| description: Background colours used for vitality. | ||
| componentName: th-vitality | ||
| expiry: November 30, 2024 |
There was a problem hiding this comment.
@duboisp What date should be provided as an expiration date for the thematic?
I've reworked the current Loss of a Loved one CSS to use Sass.
New themes for journey labs now need 4-5 lines just setting theme name, primary and secondary color. Hoping this can reduce the workload and maintenance on both of our sides.