Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a column was invisible in the Datatable, the wrong Column target was used #2464

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

bozzit
Copy link
Contributor

@bozzit bozzit commented Jan 17, 2025

Workaround was to put all invisible columns as the last columns of the table, but this fix should take care of the issue

@duboisp
Copy link
Member

duboisp commented Jan 20, 2025

Pre-approved upon review

@duboisp duboisp self-assigned this Jan 20, 2025
@duboisp
Copy link
Member

duboisp commented Jan 20, 2025

@bozzit Can you comment here the answer at the following question that describe your change (what + impact):

  • Clear and simple explanation of the change/update;
  • The impact on the sponsored department for that change/update;
  • The impact on the public for that change/update.

@bozzit
Copy link
Contributor Author

bozzit commented Jan 20, 2025

  • Change was to fix a bug with tables that have hidden columns. The hidden columns caused the formatting to apply to the wrong column
  • The bug is now fixed and the workaround of having to move the hidden columns to the end is no longer necessary
  • The bug is now fixed and the workaround of having to move the hidden columns to the end is no longer necessary

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a working example that show the functional aspect of that code addition.

May be one column for one of the tables in the existing working example can be set to invisible.

@duboisp
Copy link
Member

duboisp commented Jan 22, 2025

I added the working example. I reviewed and look good.

With the updated working example, I was able to confirm the added code get executed as expected.

@bozzit can you confirm that you tested the code you added. Once I have that we will be able to merge it.

@bozzit
Copy link
Contributor Author

bozzit commented Jan 22, 2025

@duboisp Yes I developed and tested the fix on a local copy of the datatable plugin here at PSPC

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved

@duboisp duboisp merged commit add25e0 into wet-boew:master Jan 22, 2025
1 check passed
@Garneauma Garneauma added this to the v16.1.1 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants