-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a column was invisible in the Datatable, the wrong Column target was used #2464
Conversation
Pre-approved upon review |
@bozzit Can you comment here the answer at the following question that describe your change (what + impact):
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a working example that show the functional aspect of that code addition.
May be one column for one of the tables in the existing working example can be set to invisible.
I added the working example. I reviewed and look good. With the updated working example, I was able to confirm the added code get executed as expected. @bozzit can you confirm that you tested the code you added. Once I have that we will be able to merge it. |
@duboisp Yes I developed and tested the fix on a local copy of the datatable plugin here at PSPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved
Workaround was to put all invisible columns as the last columns of the table, but this fix should take care of the issue