Main: fix word-break issue for long words in small screens #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pre-approved upon successful review and addition of working example. |
duboisp
approved these changes
Jan 14, 2025
duboisp
requested changes
Jan 14, 2025
|
@duboisp Working example added. |
EricDunsworth
added a commit
to EricDunsworth/GCWeb
that referenced
this pull request
Jan 23, 2025
wet-boew#2450 added a CSS selector that set the word-break property to break-word anywhere within the main element. But it had unexpected side effects in certain kinds of two-dimensional content, such as tables. Specifically, it could cause wide tables (even ones situated within table-responsive containers) to divide their columns improperly - resulting in individual numbers in number groupings "splitting" across lines, columns that are too narrow to fit short words on the same line, non-breaking spaces getting ignored, etc... This resolves it by adding overrides to reset the word-break properties of any table child elements to initial. Fixes wet-boew#2466.
Garneauma
added a commit
that referenced
this pull request
Jan 27, 2025
* Theme: Set word-break to initial for table children #2450 added a CSS selector that set the word-break property to break-word anywhere within the main element. But it had unexpected side effects in certain kinds of two-dimensional content, such as tables. Specifically, it could cause wide tables (even ones situated within table-responsive containers) to divide their columns improperly - resulting in individual numbers in number groupings "splitting" across lines, columns that are too narrow to fit short words on the same line, non-breaking spaces getting ignored, etc... This resolves it by adding overrides to reset the word-break properties of any table child elements to initial. Fixes #2466. * Update sites/baseline/_scaffolding.scss Co-authored-by: Garneauma <[email protected]> * Set word-break to initial for paragraphs in table cells * Prevents improper column division in cells containing paragraphs with long text (e.g. large dollar amounts, publication numbers, year ranges, etc...) * Retains break-word in paragraphs situated within table captions * Leverages a placeholder selector --------- Co-authored-by: Garneauma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.