Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: updating build dependencies #2439

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

Garneauma
Copy link
Contributor

Updating build dependencies to synchronize with WET-BOEW.

Dependent on wet-boew/wet-boew #9820 being merged.

@duboisp duboisp added this to the v16.0.0 milestone Nov 1, 2024
@Garneauma
Copy link
Contributor Author

To update when the build update is approved in WET-BOEW.

Pre-approved upon successful review.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and do work as expected when building with the WET-BOEW PR 9820. Almost ready to be approved.

Request changes only because the "package-lock.json" would need to be fully rebuild once the wet-boew along with the updated dependencies are released and this PR do reference that new wet-boew version.

@Garneauma
Copy link
Contributor Author

@duboisp The PR has been updated to use the latest version of WET-BOEW and I have installed all the new dependencies.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally.

Not with the last package-lock but I validated that the updated wet-boew dependencies was also listed there. I confirm it is there.

@duboisp duboisp merged commit 4ea7305 into wet-boew:master Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants