Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGAGE-1935] - Rooms list otimization and new visual #538

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

mateuseduardomedeiros
Copy link
Collaborator

@mateuseduardomedeiros mateuseduardomedeiros commented Oct 29, 2024

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

Chats otimizations and rooms list redesign

Summary of Changes

  • Add new rooms list visual and count
  • Change get rooms request limit from 100 to 20
  • Fix transfer room did not close the room display on the screen
  • Fix last message not show in chats contact
  • Fix broken media messages notifications because i18n

Design Files

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 5.74713% with 82 lines in your changes missing coverage. Please review.

Project coverage is 13.40%. Comparing base (786e4fa) to head (dd5c752).

Files with missing lines Patch % Lines
...uts/ChatsLayout/components/TheCardGroups/index.vue 0.00% 48 Missing ⚠️
src/store/modules/chats/rooms.js 29.41% 12 Missing ⚠️
src/utils/array.js 0.00% 7 Missing ⚠️
src/components/chats/RoomsTransferFields.vue 0.00% 4 Missing ⚠️
...ayout/components/TheCardGroups/CardGroup/index.vue 0.00% 4 Missing ⚠️
...youts/ChatsLayout/components/TheCardGroups/Tag.vue 0.00% 4 Missing ⚠️
...c/components/chats/ContactInfo/TransferSession.vue 0.00% 1 Missing ⚠️
src/store/modules/chats/roomMessages.js 0.00% 1 Missing ⚠️
src/utils/notifications.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   13.54%   13.40%   -0.14%     
==========================================
  Files         149      151       +2     
  Lines        5553     5624      +71     
  Branches     1294     1316      +22     
==========================================
+ Hits          752      754       +2     
- Misses       4801     4870      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants