Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep tabs mounted #544

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Conversation

JaiiR320
Copy link
Collaborator

Keep tabs mounted so that their cached data does not get removed when switching between tabs. This was done by wrapping components in a div and adding a style which changes the display type to block or non depending on if it is open.

Closes #158

Keep tabs mounted so that their cached data does not get removed when switching between tabs. This was don by wrapping components in a div and adding a style which changes the display type to block or non depoending on if it is open.
@JaiiR320 JaiiR320 added the bug Something isn't working label Jan 10, 2025
@JaiiR320 JaiiR320 self-assigned this Jan 10, 2025
@JaiiR320 JaiiR320 linked an issue Jan 10, 2025 that may be closed by this pull request
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:43pm

Copy link
Member

@jpfisher72 jpfisher72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes some issues with the auto-resizing bar chart for some reason. Causes it to extend beyond the screen. Looking into it before I merge these changes

Fixed an issue where clicking a cCRE in the browser would not open a new tab, but overwrite a previous one.
@jpfisher72 jpfisher72 requested review from jpfisher72 and removed request for jpfisher72 January 13, 2025 15:42
@jpfisher72 jpfisher72 merged commit a87b282 into main Jan 13, 2025
4 checks passed
@jpfisher72 jpfisher72 deleted the 158-ccre-details-are-not-properly-cached branch January 13, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cCRE details are not properly cached
2 participants