Use localstack in storage tests

[kenoir]

What does this change?

Follows #259

Instead of using the Zenko version of S3, this switches to using the Localstack version.

We may wish to use Localstack to avoid future maintenance issues with the Zenko images that don't seem to have been updated in the last 2 years, and so that we can use the ECR public versions of the Localstack images to avoid potential throttling on docker hub (which has been an issue in the past.

Note

This change required updated the tests as some of the error messages emitted by the Localstack S3 container image around bucket naming are different from the Zenko image. I have not determined which is "correct" as per comparison to S3 but allowed both.

How to test

• Run the tests, do they pass?

How can we measure success?

Tests can pass, we can release things.

Have we considered potential risks?

The differing errors may mean that Localstack is incorrect when compared to S3, we've kept both old and new error messages as valid to mitigate.

[github-actions]

Suspected binary incompatible evictions across all projects (summary)

• org.scala-lang:scala-library:2.12.20 is selected over {2.12.19, 2.12.19, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.8, 2.12.18, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19}
• org.scala-lang:scala-library:2.12.20 is selected over {2.12.19, 2.12.19, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.8, 2.12.18, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19}
• org.scala-lang:scala-library:2.12.20 is selected over {2.12.19, 2.12.19, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.8, 2.12.18, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19}
• org.slf4j:slf4j-api:2.0.16 is selected over {2.0.7, 1.7.9, 1.7.30, 1.7.30, 1.7.30, 1.7.30}
• org.slf4j:slf4j-api:2.0.16 is selected over {2.0.7, 1.7.9, 1.7.30, 1.7.30, 1.7.30}
• org.slf4j:slf4j-api:2.0.16 is selected over {2.0.7, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 1.7.9, 1.7.30, 1.7.30, 1.7.30}
• org.slf4j:slf4j-api:2.0.9 is selected over {1.7.9, 1.7.30, 1.7.30, 1.7.30}

See individual evictions stages for more detail

[paul-butcher]

Yes. This is a much better idea than my fix