Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sonatype release action #5780 #252

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

StepanBrychta
Copy link
Contributor

@StepanBrychta StepanBrychta commented Oct 1, 2024

What does this change?

Make several improvements to the release action:

  • Increase connection timeout to prevent the action from failing due to timeouts while checking the status of the published package. These timeouts are the result of a known bug in the publishing library we're using (see here). Increasing the timeout is a workaround suggested in the comments, but I'll keep an eye on the open issue and update the package if the issue gets fixed.
  • Use the Sonatype API to check if the package we are about to upload already exists. If so, exit gracefully.

How to test

The only major change is in the 'Publish to Sonatype' shell script, which can be tested locally (note that the line with the sonatypeBundleRelease command should be commented out when testing).

How can we measure success?

No more release action failures due to timeout issues.

Have we considered potential risks?

I believe this change doesn't introduce any new risks.

Copy link

github-actions bot commented Oct 1, 2024

Suspected binary incompatible evictions across all projects (summary)

  • org.scala-lang:scala-library:2.12.17 is selected over {2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.16}
  • org.scala-lang:scala-library:2.12.18 is selected over {2.12.15, 2.12.15, 2.12.17, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.15, 2.12.17, 2.12.17, 2.12.16, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.17, 2.12.17, 2.12.17, 2.12.16, 2.12.15, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.17, 2.12.17, 2.12.17, 2.12.16, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.18, 2.12.18, 2.12.18, 2.12.8, 2.12.17, 2.12.15, 2.12.15, 2.12.18, 2.12.18, 2.12.18, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.18, 2.12.18, 2.12.18, 2.12.8, 2.12.17, 2.12.15, 2.12.15, 2.12.18, 2.12.18, 2.12.18, 2.12.15, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.17, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.12, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.15, 2.12.17, 2.12.17, 2.12.16, 2.12.15, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.18, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.18, 2.12.18, 2.12.18, 2.12.18, 2.12.8, 2.12.17, 2.12.15, 2.12.15, 2.12.17, 2.12.17, 2.12.16, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.18, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.15, 2.12.18, 2.12.18, 2.12.18, 2.12.18, 2.12.8, 2.12.17, 2.12.15, 2.12.15, 2.12.17, 2.12.17, 2.12.16, 2.12.15, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.15, 2.12.15}
  • org.scala-lang:scala-library:2.12.19 is selected over {2.12.15, 2.12.15, 2.12.8, 2.12.15, 2.12.15}
  • org.slf4j:slf4j-api:2.0.4 is selected over {1.7.36, 1.7.36, 1.7.9, 1.7.30, 1.7.30, 1.7.30, 1.7.30}
  • org.slf4j:slf4j-api:2.0.4 is selected over {1.7.36, 1.7.36, 1.7.9, 1.7.30, 1.7.30, 1.7.30}
  • org.slf4j:slf4j-api:2.0.7 is selected over {1.7.9, 1.7.30, 1.7.30, 1.7.30}
  • org.slf4j:slf4j-api:2.0.7 is selected over {2.0.4, 1.7.36, 1.7.36, 1.7.9, 1.7.30, 1.7.30, 1.7.30}

See individual evictions stages for more detail

@StepanBrychta StepanBrychta force-pushed the improve-sonatype-release-action branch 28 times, most recently from 7e1eca5 to 5af2849 Compare October 1, 2024 11:02
@StepanBrychta StepanBrychta force-pushed the improve-sonatype-release-action branch from 5af2849 to db90400 Compare October 1, 2024 11:22
@StepanBrychta StepanBrychta marked this pull request as ready for review October 1, 2024 13:08
@StepanBrychta StepanBrychta force-pushed the improve-sonatype-release-action branch from db90400 to e4a8a14 Compare October 1, 2024 13:09
@StepanBrychta StepanBrychta requested a review from a team October 1, 2024 13:11
Copy link
Contributor

@kenoir kenoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@StepanBrychta StepanBrychta merged commit 17b84a9 into main Oct 2, 2024
136 checks passed
@StepanBrychta StepanBrychta deleted the improve-sonatype-release-action branch October 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants