Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #70

Merged
merged 22 commits into from
Jan 22, 2025
Merged

Bug fix #70

merged 22 commits into from
Jan 22, 2025

Conversation

ajfriedman22
Copy link
Collaborator

@ajfriedman22 ajfriedman22 commented Jan 14, 2025

Description

Fix topology parsing error to generalize default conformational swapping function to more systems. Also fix issue when restarting from checkpoint in MT-REXEE.

Type of Change

  • Bug fix

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Fix topology parsing error
  • Prevent attempted repeat swap when restarting from checkpoint file

Checklist

Starting from PR #62, external PRs must keep the following checklist in the PR.

  • I have read the contributing guidelines.
  • My code follows the project’s coding style and is free from linting errors examined by flake8.
  • My code comes with docstrings that follow the NumPy docstrings standard.
  • I have updated the documentation in the docs directory if my changes affect the project's functionality or usage.
  • I have added new tests for new features or changes to existing features. The code coverage is at least 90%.
  • My code passes all unit tests and CI tests on CircleCI.

@ajfriedman22 ajfriedman22 requested a review from wehs7661 January 14, 2025 19:37
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 82.52427% with 18 lines in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (4ffcb5c) to head (5088d7b).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
ensemble_md/utils/coordinate_swap.py 80.43% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   96.01%   95.13%   -0.88%     
==========================================
  Files          11       11              
  Lines        2583     2610      +27     
==========================================
+ Hits         2480     2483       +3     
- Misses        103      127      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajfriedman22 ajfriedman22 merged commit b39d7e1 into master Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants