Fix resolveRelUrl() attempting to use invalid URLs #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Apr 8, 2024
•
ikreymer
commented
- just use URL class instead of element for absolute URL resolving (removing old code)
- specifically check baseURI for https:// or http://
- only use valid http/https baseURI as base rewriting URL
- if passed in doc doesn't have an http/https base URI, check window document, then replay-top document.
- fixes Fix resolveRelUrl using invalid URL for rewriting #139
- fixes [Replay Bug]: Players not rendering Scalar crawls in Chrome replayweb.page#300
- bump version to 3.7.3
…blank (and other disallowed prefixes) default to window.document if passed in document does not have a valid URL (eg. about:blank) specifically check for https:// or http:// fixes #139
ikreymer
force-pushed
the
fix-reloverride
branch
from
adfed55
to
be2786e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.