Fix regression in <object> tag rewriting (#167)

* fix <object> tag rewrite: don't attempt to rewrite for unknown type * bump to 3.7.13
webrecorder · Aug 13, 2024 · 6895131 · 6895131
1 parent 3b8d78f
commit 6895131
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@webrecorder/wombat",
-  "version": "3.7.12",
+  "version": "3.7.13",
   "main": "index.js",
   "license": "AGPL-3.0-or-later",
   "author": "Ilya Kreymer, Webrecorder Software",

diff --git a/src/wombat.js b/src/wombat.js
@@ -2277,19 +2277,21 @@ Wombat.prototype.rewriteElem = function(elem) {
             altElemName = 'IMG';
           }
 
-          var newElem = this.$wbwindow.document.createElement(altElemName);
-          for (var i = 0; i < elem.attributes.length; i++) {
-            var attr = elem.attributes[i];
-            var name = attr.name;
-            if (name === 'data') {
-              name = 'src';
+          if (altElemName) {
+            var newElem = this.$wbwindow.document.createElement(altElemName);
+            for (var i = 0; i < elem.attributes.length; i++) {
+              var attr = elem.attributes[i];
+              var name = attr.name;
+              if (name === 'data') {
+                name = 'src';
+              }
+              this.wb_setAttribute.call(newElem, name, attr.value);
             }
-            this.wb_setAttribute.call(newElem, name, attr.value);
-          }
 
-          elem.parentElement.replaceChild(newElem, elem);
-          changed = true;
-          break;
+            elem.parentElement.replaceChild(newElem, elem);
+            changed = true;
+            break;
+          }
         }
 
         changed = this.rewriteAttr(elem, 'data', true);