Adjusted WARC-Date for Revisit-Records #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted method make_index_revisit: When creating the revisit record the information of the WARC Date of the index/default file is passed on so that the revisit record has the same WARC-Date as the index file. This is helpful in Playback. The actual creation date is added is WARC-Creation-Date.
corrected creation_date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue 31 (hopefully):
Changed method:
make_index_revisit
Information about the WARC-Date of the index record is passed on to the create_revisit_record-method, so that the revisit record gets the same WARC-Date entry as the index record.
Accordingly, the revisit record also gets a WARC-Creation-Date with the actual timestamp of the creation of the record.
As far as tested it works both with --fixed-dt and with the original time stamp of files that are "warced".