Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for nested multi WACZ loading #216

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix for nested multi WACZ loading #216

merged 2 commits into from
Nov 22, 2024

Conversation

ikreymer
Copy link
Member

Fix regression introduced during TypeScript conversion

  • remove unneeded size var that default to 0, prevented a full load since never null
  • use length instead of size (initial state set to null) in base class
  • fixes Regression for Nested WACZ loading #215

@ikreymer
regression fix: fix multi-WACZ replay, #215
4d09a04 
- remove unneeded size var that default to 0, prevented a full load
- do full load if length is null, initial state set to null in base class
@ikreymer
bump to 2.20.7
ad390b3
@ikreymer ikreymer requested a review from tw4l November 22, 2024 22:25
tw4l
tw4l approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, seems to be working well

@ikreymer ikreymer merged commit e9a15d2 into main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression for Nested WACZ loading
2 participants
@ikreymer @tw4l