Rewriting Global + Live Proxy Fixes #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd skip wrapper override if already overridden in script, eg. 'parent', 'window', etc... - fix for webrecorder/wombat#127 examples: update live proxy example to support wayback replay if timestamp is provided
- when proxying to an existing web archive, remove the web archive prefix from the redirect URL to avoid double-adding the redirect
- fix parsing of inline attributes: parse if starts with 'javascript:' or property name starts with on* - rewrite: replace newlines for inline attr before acorn parse, and also after wrap - tests: add tests for inline attribute parsing, including wrapping bump to 2.16.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Globals:
Live Proxy: