Improve keyboard accessibility of Vue timeline #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by Lee Davey <[email protected]>
tw4l
force-pushed
the
issue-846-timeline-accessibility
branch
from
f30803e
to
f384f47
Compare
ikreymer
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by Lee Davey [email protected]
Fixes #846
Description
Modifies tabindexes in Vue timeline to be set based on whether there are snapshots in a given period so that users navigating via keyboard do not need to tab through empty periods.
Motivation and Context
This change will make our application much easier to use for users who navigate via keyboard.
Screenshots (if appropriate):
Types of changes
Checklist: