Additional logging for CI #1156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add redis_storage param
set 'max_crawl_scale' in values.yaml to indicate max possible scale, used to create crawl-instance-{0, N}
priority classes, each with lower priority
allows crawl instance 0 to preempt crawls with more instances (and lower priorities)
eg. 2nd instance of a crawl can preempt 3rd instance of another, and a new crawl (1st instance)
can preempt 2nd instance of another crawl
- ensure redis pod is deleted last - start deletion in background as soon as crawl is done - operator may call finalizer with old state: if not finished but in finalizer, attempt to cancel, and throw 400 if already canceled - recreate redis in finalizer from yaml to avoid change event
- support reconciling desired and actual scale - if desired scale is lower, attempt to gracefully shutdown each instance via new redis 'stopone' key - once each instance above > desired scale exit successfully, adjust the status.scale down to clean up pods. also clean up redis per-instance state when scaling down
…have been running for >60 seconds, not immediately
add placeholder for adding podmetrics as related resources fix canceled condition
- pods explicitly deleted if spec.restartTime != status.restartTime, then updates status.restartTime - use force_restart to remove pods for one sync response to force deletion - update to latest metacontroller v4.11.0 - add --restartOnError flag for crawler
Co-authored-by: Tessa Walsh <[email protected]>
Co-authored-by: Tessa Walsh <[email protected]>
cancel crawl test: just wait until page is found, not necessarily done
- print previous log - print pod statuses for failed crawls
to ensure get original log (previous container logs may not be available)
ikreymer
force-pushed
the
more-failed-logging
branch
from
139ec67
to
b2856c8
Compare
if logging lines/no restart mode, fail crawl when pod fails
…y handled via mark_finished
…d failed! disable disk_utiliazation_threshold to avoid unnecessary interrupts
|
These changes / branch has been merged into #1149 changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional logging for debugging failed crawls on CI: