Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in QA exclude check, which resulted in all URLs being excluded #697

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix typo in QA exclude check, which resulted in all URLs being excluded #697

merged 2 commits into from
Oct 8, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Oct 4, 2024

  • ensure exclusions now work as expected in replay mode
  • add test for using --exclude with replay

@ikreymer ikreymer requested a review from tw4l October 7, 2024 16:37
tw4l
tw4l approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch!

tests/qa_compare.test.js Show resolved Hide resolved
@ikreymer ikreymer merged commit 157ac34 into main Oct 8, 2024
4 checks passed
@ikreymer ikreymer deleted the fix-qa-exclude branch October 8, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikreymer @tw4l