Implemented option for FullPage screenshot after the behaviours have run #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this - i think it would be clearer if it was part of the existing |
|
Reopening after adding changes |
|
@ikreymer I've reimplemented the changes as suggested, hope this can be useful |
tw4l
approved these changes
Nov 5, 2024
|
@fservida Looks like we need to run the auto-formatter before merging to resolve linting issues. Would you mind pushing a commit to this branch after running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new option to take the FullPage screenshot after the behaviours have run instead of before.
This allows to capture elements that might not be fully loaded until the whole page is visited.
I only implemented for fullpage as I think it is the only screenshot where this is useful and the only case where I would need it, as it can include content not currently in frame. Feel free to expand on that as needed.
Related to #486
Tested with custom docker, though I had to ensure setuptools v71 as else it would not build.