Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behavior logging tweaks, add netIdle #381

Merged
merged 4 commits into from
Sep 15, 2023
Merged

behavior logging tweaks, add netIdle #381

merged 4 commits into from
Sep 15, 2023

Conversation

ikreymer
Copy link
Member

Slight improvement to behavior logging, indicate if one of the frames' promises has failed.

bump to latest browsertrix-behaviors

…ccepting any iframes!

now used not only for link extraction but also to run() behaviors
Dockerfile: add commented out line to use local behaviors.js
Copy link
Contributor

@Chickensoupwithrice Chickensoupwithrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fairly small change, detection of iframe seems reasonable

@ikreymer ikreymer merged commit 3c9be51 into main Sep 15, 2023
2 checks passed
@ikreymer ikreymer deleted the behavior-log-tweaks branch September 15, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants