optimize link extraction: (fixes #376) #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Sep 14, 2023
ikreymer
commented
- dedup URLs in browser first
- don't return entire list of URLs, process one-at-a-time via registered callback function
- add exposeFunction per page in setupPage, then register 'addLink' callback for each pages' handler
- optimize addqueue: atomically check if already at max urls and if url already seen in one redis call, as links can be added async
- better logging: log rejected promises for link extraction
- browser: set protocolTimeout to 0 to avoid CDP timeout errors
tw4l
reviewed
Sep 15, 2023
- dedup urls in browser first - don't return entire list of URLs, process one-at-a-time via callback - add exposeFunction per page in setupPage, then register 'addLink' callback for each pages' handler - optimize addqueue: atomically check if already at max urls and if url already seen in one redis call - better logging: log rejected promises for link extraction
- change error state to differntiate limit hit vs dupe url - add QueueState enum to indicate success, limit hit, or dupe url
ikreymer
force-pushed
the
opt-link-extraction
branch
from
247b9a9
to
57150c7
Compare
tw4l
approved these changes
Sep 15, 2023
|
Also added additional test which ensures exact page limit is reached, would've caught the early limit issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.