logging: resolve confusion with 'crawl done' not being written to log… #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, because the log is itself stored in the WACZ: (fixes #365) - keep log file open until end, even if its being written to WACZ - add logging of 'crawling done' when crawling is done (writing to WACZ or not) - add debug logging of 'end of log file' to indicate log file is being added to WACZ and nothing else will be added there in the WACZ.
|
Wouldn't we still want to close the log once the log has been written to the WACZ? On second thought it doesn't matter too much since the crawler will spin down anyway? Still think it would be "good practice"? |
Yea, the process and container will exit soon after, I suppose could add it back in for successful exit. |
tw4l
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, because the log is itself stored in the WACZ: (fixes #365)