-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MultiMeter #121
Update MultiMeter #121
Conversation
Hi Alex, thanks for your contribution and for sharing your nice plugin. To add to our list edit the respective json file and our build system will do the rest, I think you need to edit this one: https://github.com/webprofusion/OpenAudio/blob/master/data/plugins.json |
To encourage adoption of your plugin I'd also suggest having a website for users to download the prebuilt plugin, or use github releases (or github pages etc) as only a very tiny part of your audience can build from source. |
Hi Christopher, Thank you very much for pointing out the unnecessary changes in my previous commit - I have reverted it and modified the plugins json file for your review. I will also create a GitHub release soon. Thanks again for your great advice! Sincerely, |
Hi Christopher, I hope that you are doing well! I just saw that the generation was not successful - is there any possibility that you have any idea of why that is the case? Thanks in advance, and I'm looking forward to hearing back from you! Sincerely, |
@RealAlexZ ah thanks it's just failing on the test to check the entries are in alphabetical order, if you move yours down to M that should fix it. |
Hello Christopher, I hope that you are doing well! I am very sorry for the late reply - I somehow got terribly sick last week and was not able to get back to you on time. I have now checked that the json file is in the right alphabetical order, and I would really appreciate if there is any chance that you can generate the README again! Thanks in advance, and I am looking forward to hearing back from you soon. Sincerely, |
abe21d9
into
webprofusion:master
Thanks Alex, that's all merged and published now, much appreciated. |
Hi,
I hope that you are doing well! I am hoping to add my recently completed open-sourced plugin, MultiMeter, to your repository. I immensely appreciate your consideration, and thank you for compiling this wonderful list!
Best,
Alex