Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MultiMeter #121

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

RealAlexZ
Copy link
Contributor

Hi,

I hope that you are doing well! I am hoping to add my recently completed open-sourced plugin, MultiMeter, to your repository. I immensely appreciate your consideration, and thank you for compiling this wonderful list!

Best,
Alex

@webprofusion-chrisc
Copy link
Contributor

Hi Alex, thanks for your contribution and for sharing your nice plugin. To add to our list edit the respective json file and our build system will do the rest, I think you need to edit this one: https://github.com/webprofusion/OpenAudio/blob/master/data/plugins.json

@webprofusion-chrisc
Copy link
Contributor

To encourage adoption of your plugin I'd also suggest having a website for users to download the prebuilt plugin, or use github releases (or github pages etc) as only a very tiny part of your audience can build from source.

@RealAlexZ
Copy link
Contributor Author

Hi Christopher,

Thank you very much for pointing out the unnecessary changes in my previous commit - I have reverted it and modified the plugins json file for your review. I will also create a GitHub release soon. Thanks again for your great advice!

Sincerely,
Alex

@RealAlexZ
Copy link
Contributor Author

Hi Christopher,

I hope that you are doing well! I just saw that the generation was not successful - is there any possibility that you have any idea of why that is the case? Thanks in advance, and I'm looking forward to hearing back from you!

Sincerely,
Alex

@webprofusion-chrisc
Copy link
Contributor

@RealAlexZ ah thanks it's just failing on the test to check the entries are in alphabetical order, if you move yours down to M that should fix it.

@RealAlexZ
Copy link
Contributor Author

Hello Christopher,

I hope that you are doing well! I am very sorry for the late reply - I somehow got terribly sick last week and was not able to get back to you on time. I have now checked that the json file is in the right alphabetical order, and I would really appreciate if there is any chance that you can generate the README again! Thanks in advance, and I am looking forward to hearing back from you soon.

Sincerely,
Alex

@webprofusion-chrisc webprofusion-chrisc merged commit abe21d9 into webprofusion:master Feb 23, 2024
2 of 3 checks passed
@webprofusion-chrisc
Copy link
Contributor

Thanks Alex, that's all merged and published now, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants