With the posibility of the MutationEvent being deprecated, check if exists prior to usage #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists prior to usage
|
cc: @coreh |
|
Hey there @poloka, unfortunately I'm no longer a member of the webmodules GitHub organization, so I no longer have commit access to merge this. 😕 |
|
cc: @TooTallNate |
|
Awesome, thanks @TooTallNate . |
|
@TooTallNate, could you release a 1.0.3 with this fix? |
|
Ya, done
…On Tue, Jul 25, 2017 at 10:51 AM, Greg Howdeshell ***@***.***> wrote:
@TooTallNate <https://github.com/tootallnate>, could you release a 1.0.3
with this fix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEWWFBhugyKHcI1reTvns5aopp1KAi3ks5sRisXgaJpZM4Obgap>
.
|
This was referenced Jul 26, 2017
kafkahw
pushed a commit
to oracle-samples/xfc
that referenced
this pull request
Jul 26, 2017
* Update mutation-observer dependency to include MutationEvent undefined fix webmodules/mutation-observer#8 * update contributors.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an isssue with a configuration of IE where the MutationEvent is no longer a valid Object. With the notation of its deprecation, adding a check in case the client upgrades to a version no longer supporting the MutationEvent to keep this polyfill from throwing a javascript exception.