[azure-metrics-exporter]: fix broken servicemonitor.metricprobe.yaml #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.yaml ## What & Why? This fixes the invalid condition (to check for namespaceSelector) caused by #56
x418
changed the title
x418
changed the title
|
This PR also seems to fix #60 |
|
Is there any date planned for his to get integrated? |
|
@mblaschke approve pls |
| {{- if .Values.prometheus.monitor.namespaceSelector }} | ||
| namespaceSelector: {{ toYaml .Values.prometheus.monitor.namespaceSelector | nindent 4 }} | ||
| {{- if $root.Values.prometheus.monitor.namespaceSelector }} | ||
| namespaceSelector: {{ toYaml $root.Values.prometheus.monitor.namespaceSelector | nindent 4 }} | ||
| {{- else }} | ||
| namespaceSelector: | ||
| matchNames: | ||
| - {{ template "azure-metrics-exporter.namespace" . }} |
mblaschke
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This fixes the invalid condition (to check for namespaceSelector) that prevents template from rendering.
i.e. When probes exist, the template no longer renders as shown below
Which issue this PR fixes
Special notes for your reviewer
Checklist
[azure-metrics-exporter])