-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alfie #287
base: master
Are you sure you want to change the base?
Add Alfie #287
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 82.09% 82.01% -0.08%
==========================================
Files 79 79
Lines 6642 6657 +15
Branches 525 527 +2
==========================================
+ Hits 5453 5460 +7
- Misses 1069 1077 +8
Partials 120 120 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit wary about adding many special cases. Sometimes the better solution is finding a better naming scheme for all files... Maybe just using the image file name like
namer = joinPathPartsNamer((), (-3, -2, -1))
I wasn't sure about this one. Alfie is on a WordPress site, but the image names are all pretty much two-digit fields like |
Add Alfie from https://buttsmithy.com/
The format attempts to normalize the date so it is in lexical order, otherwise everything comes in at things like
8.jpg
for a comic that has over a thousand pages. There are a few exceptions (the if blocks) due to typos or mistakes.