Skip to content

merge_pr_50258

Compare
Choose a tag to compare
@github-actions github-actions released this 23 Jan 23:14

Convert 2d.composite WPT tests using images to promise tests

This simplifies the offscreen and worker tests a lot, but it also
allows them to be implemented with the same structure as all other
tests, with three distinct sections:

  • Draw background.
  • Draw foreground.
  • Assert

This will help in the follow-up CLs, where these tests will be
migrated to the new test generator. Having the same structure will
allow all of these tests to have a shared base implementation.

The changes in gentestutils.py are pretty hacky, but it's hard to do
anything better given the state of this file. Since this script will be
deleted soon, there's no point in spending time to implement this in
a better way.

Bug: 40207206
Change-Id: I85eab5c12f328bda699d92ab8aecb804100e9d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192518
Reviewed-by: Andres Ricardo Perez [email protected]
Commit-Queue: Jean-Philippe Gravel [email protected]
Cr-Commit-Position: refs/heads/main@{#1410563}