Skip to content

merge_pr_49006

Compare
Choose a tag to compare
@github-actions github-actions released this 06 Nov 18:54

ListItemOrdinal should use explicit_value_ when the element's counter-set CSS property is set to empty

The patch1 ensures that ListItemOrdinal does not use explicit_value_
when the counter-set is set. However, if the counter-set is assigned
an invalid value, ListItemOrdinal value will remain unchanged.
Consider this test case:

<!doctype html>
<ol>
  <li value="5" style="counter-set: list-item 1"></li>
</ol>
<script>
document.body.offsetLeft;
document.querySelector("li").style.counterSet = "";
</script>

The li element should show "5" as the counter-set is not set.
This patch ensures that ListItemOrdinal should use explicit_value_
when counter-set is not set.

Bug: 40205385
Change-Id: I0c9eeda21ef6890e727a6f42c464af412b08eb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992536
Reviewed-by: Joey Arhar [email protected]
Commit-Queue: Peng Zhou [email protected]
Cr-Commit-Position: refs/heads/main@{#1379108}