[Gecko Bug 1919248] transform WPT <to-javascript-url-script-src.html>'s async sub-tests to promise-tests and remove checking the securitypolicyevent's target element. #48884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o promise-tests and remove checking the securitypolicyevent's target element. Gecko doesn't set the securitypolicyevent violation's target element, which prevented the async tests from passing with Gecko. Setting the violation's target element isn't specified ( w3c/webappsec-csp#687). Promise-based tests allow removing checking the target element, because the tests are run in sequence (https://web-platform-tests.org/writing-tests/testharness-api.html#promise-tests). Differential Revision: https://phabricator.services.mozilla.com/D227160 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919248 gecko-commit: b941985be92395c909b233ecfbba356f6d0db149 gecko-reviewers: smaug
wpt-pr-bot
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gecko doesn't set the securitypolicyevent violation's target element,
which prevented the async tests from passing with Gecko.
Setting the violation's target element isn't specified (
w3c/webappsec-csp#687).
Promise-based tests allow removing checking the target element, because
the tests are run in sequence
(https://web-platform-tests.org/writing-tests/testharness-api.html#promise-tests).
Differential Revision: https://phabricator.services.mozilla.com/D227160
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919248
gecko-commit: b941985be92395c909b233ecfbba356f6d0db149
gecko-reviewers: smaug