Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State viewport height assumption and make a test fit that definition #45161

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 18, 2024

This matches the changes made to the img element test in #7644.

This matches the changes made to the img element test in #7644.
* The device has a viewport width of at least 800px.
* The device has viewport dimensions of at least 800px by 600px.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this RFC material?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't know. I was hoping that given the discussion in #7642 this was just missing information. Not sure I want to make the time to write an RFC for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably OK? Although having said that I don't think we currently enforce a minimum window size in wptrunner, except for reftests, so maybe we should have a followup issue to actually implement this? In which case a small RFC wouldn't hurt I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed web-platform-tests/rfcs#188 as follow-up. Is that sufficient to land this change? I primarily care about getting this test fixed, but it seems good to update the documentation as well as per the discussion many years ago.

@annevk annevk merged commit fa4807c into master Mar 19, 2024
21 checks passed
@annevk annevk deleted the annevk/viewport branch March 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants