Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one-way bindings for wpt-metadata and wpt-amend-metadata #4187

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Use one-way bindings for wpt-metadata and wpt-amend-metadata #4187

merged 8 commits into from
Jan 23, 2025

Conversation

past
Copy link
Member

@past past commented Jan 4, 2025 •
edited
Loading

This migration was a bit larger than usual due to the fact that the metadata component and the triage component interact so closely. The main changes are:

  • Removal of notify: true and change double angle brackets to double brackets.
  • Use get/set to let Polymer properly detect array property updates.
  • DOM manipulation logic is now encapsulated within methods to better adhere to Polymer's data flow principles.

@past past requested a review from KyleJu January 17, 2025 00:30
@past past mentioned this pull request Jan 17, 2025
Merged
KyleJu
KyleJu reviewed Jan 18, 2025
View reviewed changes
webapp/components/wpt-metadata.js Show resolved Hide resolved
webapp/components/test-file-results-table.js Show resolved Hide resolved
webapp/views/wpt-results.js Show resolved Hide resolved
webapp/views/wpt-results.js Show resolved Hide resolved
@KyleJu
Copy link
Collaborator

KyleJu commented Jan 18, 2025 •
edited
Loading

Screen.recording.2025-01-17.4.15.36.PM.webm

How the upward data binding for selectedMetadata is being used. The first example is wpt.fyi prod and the second example is this PR (which is broken in this change).

@past
Copy link
Member Author

past commented Jan 23, 2025

This is ready now for another review pass.

@past past requested a review from KyleJu January 23, 2025 16:24
KyleJu
KyleJu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@KyleJu KyleJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks for the changes!

@past past merged commit a4e4797 into main Jan 23, 2025
12 checks passed
@past past deleted the past/wpt-amend-metadata-bindings branch January 23, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleJu KyleJu KyleJu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@past @KyleJu