Skip to content

Commit

Permalink
Chromium bug searches should use the new URL (#4204)
Browse files Browse the repository at this point in the history
* Chromium bug searches should use the new URL
* Update the Chromium bug tracker URL in more places
  • Loading branch information
past authored Jan 23, 2025
1 parent a4e4797 commit 7653347
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 17 deletions.
6 changes: 3 additions & 3 deletions api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -576,20 +576,20 @@ __`product`__ : browser[version[os[version]]]. e.g. `chrome-63.0-linux`

#### Post Examples
- POST /api/metadata?product=chrome\&product=firefox \
exists:='[{"link":"bugs.chromium.org"}]'
exists:='[{"link":"issues.chromium.org"}]'

<details><summary><b>Example JSON</b></summary>

```json
{
"/IndexedDB/bindings-inject-key.html": [
{
"url": "bugs.chromium.org/p/chromium/issues/detail?id=934844"
"url": "issues.chromium.org/issues/934844"
}
],
"/html/browsers/history/the-history-interface/007.html": [
{
"url": "bugs.chromium.org/p/chromium/issues/detail?id=592874"
"url": "issues.chromium.org/issues/592874"
}
]
}
Expand Down
6 changes: 3 additions & 3 deletions api/metadata_handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ func TestMetadataHandler_POST_MissingProducts(t *testing.T) {
body :=
`{
"exists": [{
"link": "bugs.chromium.org"
"link": "issues.chromium.org"
}]
}`
bodyReader := strings.NewReader(body)
Expand All @@ -309,7 +309,7 @@ func TestMetadataHandler_POST_NotLink(t *testing.T) {
body :=
`{
"exists": [{
"pattern": "bugs.chromium.org"
"pattern": "issues.chromium.org/"
}]
}`
bodyReader := strings.NewReader(string(body))
Expand All @@ -327,7 +327,7 @@ func TestMetadataHandler_POST_NotJustLink(t *testing.T) {
`{
"exists": [{
"and": [
{"pattern": "bugs.chromium.org"},
{"pattern": "issues.chromium.org"},
{"link": "abc"}
]
}]
Expand Down
4 changes: 2 additions & 2 deletions api/query/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,11 @@ Same as satuts, but with a specific product-spec.

Search untriaged issues -

chrome:fail and !link:bugs.chromium.org
chrome:fail and !link:issues.chromium.org

Search triaged issues -

chrome:pass and link:bugs.chromium.org
chrome:pass and link:issues.chromium.org

#### triaged

Expand Down
4 changes: 2 additions & 2 deletions webapp/components/test/test-search.html
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,8 @@
test('simple link search', () => {
assertQueryParse('link:2dcontext', {exists: [{link: '2dcontext'}]});
assertQueryParse(
'link:bugs.chromium.org/p/chromium/issues/detail',
{exists: [{link: 'bugs.chromium.org/p/chromium/issues/detail'}]}
'link:issues.chromium.org/issues/',
{exists: [{link: 'issues.chromium.org/issues/'}]}
);
});

Expand Down
12 changes: 6 additions & 6 deletions webapp/components/test/wpt-amend-metadata.html
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,12 @@
assert.deepEqual(appFixture.displayedMetadata, expected);
});
test('getSearchURL', () => {
expect(appFixture.getSearchURL('/a/b/*', 'chrome')).to.equal('https://bugs.chromium.org/p/chromium/issues/list?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.html', 'chrome')).to.equal('https://bugs.chromium.org/p/chromium/issues/list?q="/a/b"');
expect(appFixture.getSearchURL('/a/b', 'chrome')).to.equal('https://bugs.chromium.org/p/chromium/issues/list?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.any.html', 'chrome')).to.equal('https://bugs.chromium.org/p/chromium/issues/list?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.worker.html', 'chrome')).to.equal('https://bugs.chromium.org/p/chromium/issues/list?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.html', 'edge')).to.equal('https://bugs.chromium.org/p/chromium/issues/list?q="/a/b"');
expect(appFixture.getSearchURL('/a/b/*', 'chrome')).to.equal('https://issues.chromium.org/issues?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.html', 'chrome')).to.equal('https://issues.chromium.org/issues?q="/a/b"');
expect(appFixture.getSearchURL('/a/b', 'chrome')).to.equal('https://issues.chromium.org/issues?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.any.html', 'chrome')).to.equal('https://issues.chromium.org/issues?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.worker.html', 'chrome')).to.equal('https://issues.chromium.org/issues?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.html', 'edge')).to.equal('https://issues.chromium.org/issues?q="/a/b"');
expect(appFixture.getSearchURL('/a/b.html', 'firefox')).to.equal('https://bugzilla.mozilla.org/buglist.cgi?quicksearch="/a/b"');
expect(appFixture.getSearchURL('/a/b.html', 'safari')).to.equal('https://bugs.webkit.org/buglist.cgi?quicksearch="/a/b"');
expect(appFixture.getSearchURL('/a/b.html', 'wktr')).to.equal('https://bugs.webkit.org/buglist.cgi?quicksearch="/a/b"');
Expand Down
2 changes: 1 addition & 1 deletion webapp/components/wpt-amend-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ class AmendMetadata extends LoadingState(PathInfo(ProductInfo(PolymerElement)))
}

if (product === 'chrome' || product === 'chromium' || product === 'edge') {
return `https://bugs.chromium.org/p/chromium/issues/list?q="${testName}"`;
return `https://issues.chromium.org/issues?q="${testName}"`;
}

if (product === 'deno') {
Expand Down

0 comments on commit 7653347

Please sign in to comment.