Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New web app manifest features #2078

Merged
merged 18 commits into from
Nov 21, 2024
Merged

New web app manifest features #2078

merged 18 commits into from
Nov 21, 2024

Conversation

captainbrosset
Copy link
Contributor

This isn't a complete list, but it's a good start.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 24, 2024
@captainbrosset captainbrosset requested a review from ddbeck October 31, 2024 13:15
ddbeck
ddbeck reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and a question. Cheers!

features/manifest.yml.dist Outdated Show resolved Hide resolved
features/manifest.yml Outdated Show resolved Hide resolved
features/app-shortcuts.yml Outdated Show resolved Hide resolved
features/app-share-target.yml Outdated Show resolved Hide resolved
features/app-share-target.yml Outdated Show resolved Hide resolved
features/app-protocol-handling.yml Outdated Show resolved Hide resolved
features/app-protocol-handling.yml Outdated Show resolved Hide resolved
features/app-file-handling.yml Outdated Show resolved Hide resolved
captainbrosset and others added 8 commits November 6, 2024 07:54
ddbeck
ddbeck reviewed Nov 6, 2024
View reviewed changes
features/app-file-handling.yml Outdated Show resolved Hide resolved
features/manifest.yml.dist Outdated Show resolved Hide resolved
features/app-file-handling.yml Outdated Show resolved Hide resolved
features/app-file-handling.yml Outdated Show resolved Hide resolved
@captainbrosset
Copy link
Contributor Author

@ddbeck I think this is now about ready. The BCD changes have landed and we've got them here. There's a few more manifest-related features that can be created, but those can always be added later.

ddbeck
ddbeck approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm happy with this too. I have one question and one suggestion, but this is super close to landing. You're welcome to merge this after you've considered (and/or acted on) the suggestions. Thank you!

features/manifest.yml Show resolved Hide resolved
features/app-share-target.yml Outdated Show resolved Hide resolved
@captainbrosset captainbrosset mentioned this pull request Nov 21, 2024
Open
@captainbrosset captainbrosset enabled auto-merge (squash) November 21, 2024 14:54
@captainbrosset captainbrosset merged commit f578f22 into main Nov 21, 2024
3 checks passed
@captainbrosset captainbrosset deleted the manifest branch November 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainbrosset @ddbeck