ci: upload binaries as workflow artifacts #4484
Open
+23
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Slightly improve the upload binary CI job. Since I couldn't find a way to create a "generic" GH package, I suggest starting by replacing the out-commented AWS S3 upload with upload-artifact-action. This will keep the binaries available for the default project retention period (30 days)?
Why was this change made?
I have accidentally reformatted this code several times in other PR, and in general I am not a big fan of out-commented code. We can always find old things in the Git history.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes