Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move deps to dev deps #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: move deps to dev deps #179

wants to merge 1 commit into from

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Jan 7, 2021

防止 npm/github 安装默认装了几十个依赖。

dlhandsome
dlhandsome reviewed Jan 29, 2021
View reviewed changes
package.json
"typescript": "^3.0.1",
"uglify-js": "^3.1.10"
},
"dependencies": {
"base-64": "^0.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-64 是生产环境依赖的库，不应该移除的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是，dist 已经打包成 flat bundle 了（已经内联）。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlhandsome dlhandsome dlhandsome left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambar @dlhandsome