Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NinetyFive #9032

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add NinetyFive #9032

merged 2 commits into from
Feb 4, 2025

Conversation

juaoose
Copy link
Contributor

@juaoose juaoose commented Jan 7, 2025

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.

My package is ...

My package is similar to other code assistants, however, it:

  1. Provides a free mode.
  2. Uses a different backend which we're optimizing for speed.

@juaoose
Copy link
Contributor Author

juaoose commented Jan 15, 2025

Any feedback is appreciated

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: NinetyFive
Results help

Packages added:
  - NinetyFive

Processing package "NinetyFive"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

@braver
Copy link
Collaborator

braver commented Jan 26, 2025

  • Your settings aren't exposed in the Package Settings menu, nor in the command palette.
  • As always for packages like this, the readme must be clear and unambiguous as to how and when code might leave the user's machine (for training or otherwise). Ideally the users control this from project to project and explicitly opt-in to that.

@juaoose
Copy link
Contributor Author

juaoose commented Jan 31, 2025

  • Your settings aren't exposed in the Package Settings menu, nor in the command palette.
  • As always for packages like this, the readme must be clear and unambiguous as to how and when code might leave the user's machine (for training or otherwise). Ideally the users control this from project to project and explicitly opt-in to that.

Updated!

repository/n.json Outdated Show resolved Hide resolved
@braver
Copy link
Collaborator

braver commented Feb 1, 2025

Be careful that you don't run into potential case sensitivity issues with your package name. Especially in file paths like those in your main menu file. But also elsewhere you're mixing NinetyFive and Ninetyfive.

@juaoose
Copy link
Contributor Author

juaoose commented Feb 3, 2025

Be careful that you don't run into potential case sensitivity issues with your package name. Especially in file paths like those in your main menu file. But also elsewhere you're mixing NinetyFive and Ninetyfive.

Thanks for catching this! I've made the updates.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: NinetyFive
Results help

Packages added:
  - NinetyFive

Processing package "NinetyFive"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

@braver braver merged commit ca5e2d0 into wbond:master Feb 4, 2025
2 checks passed
@juaoose juaoose deleted the ninetyfive branch February 4, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants