Dependencies installation is reworked in Installation assistant #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-for-confirmation-before-installing-dependencies
6 tasks
c-bordon
previously approved these changes
Jun 13, 2024
…k-for-confirmation-before-installing-dependencies
c-bordon
approved these changes
Jun 18, 2024
c-bordon
deleted the
change/2879-installation-assistant-must-ask-for-confirmation-before-installing-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to rework the dependencies installation of the Installation assistant. The original aim of this development is to make the Installation assistant ask for permission to install the necessary dependencies in the performed installation.
Before, the script installed the necessary dependencies for the installation, without asking the user for confirmation. Now, to control this, a new parameter
-id|--install-dependencieshas been added. If the user wants the Installation assistant to install the dependencies automatically, a new parameter must be added. Otherwise, the installation will be stopped if a dependency is required.Example:
Note
WARNING: To perform the installation, the following package/s must be installed: lsof, openssl, software-properties-common. The following package/s will be removed after the installation: lsof, openssl. Add the -id|--install-dependencies parameter to install them automatically or install them manually.
Other changes
Other changes and improvements have been added:
WIAterm should not be used anymore as it can be confusing.lsofandopensslare not installed separately, they belong to the global list of dependencies. These dependencies will be installed only when necessary.installCommon_installCheckDependenciesandinstallCommon_installPrerequisitesfunctions are removed and are unified into theinstallCommon_installDependenciesfunction.Tests
🟢 Validation of the new parameter: Installation assistant must ask for confirmation before installing dependencies #2879 (comment)
🟢 AIO installation: Installation assistant must ask for confirmation before installing dependencies #2879 (comment)
🟢 Wazuh indexer installation: Installation assistant must ask for confirmation before installing dependencies #2879 (comment)
🟢 Wazuh manager installation: Installation assistant must ask for confirmation before installing dependencies #2879 (comment)
🟢 Wazuh dashboard installation: Installation assistant must ask for confirmation before installing dependencies #2879 (comment)
🟢 Testing dashboard port change: Installation assistant must ask for confirmation before installing dependencies #2879 (comment)