Resolve dependency order on Java installation for ODFE #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okynos
suggested changes
Jun 24, 2021
There was a problem hiding this comment.
Hello @jondecamp,
Thanks for your contribution. We have seen that this change has an incorrect behaviour in cases where perform_installation is set to false. This variable is set to false in wazuh-odfe-production-ready.yml. Let me suggest you the following change: you could split the blocks to keep the logic and move the local_actions between both blocks. See one example:
- block:
name: Provide redhat
...
name: Provide debian
...
when: perform_installation
- import_tasks: local_actions
- block:
name: The rest of tasks
when: perform_installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #602 - installing Java before running local_actions, which depends on Java.