Blockchain updates for L2 extension #1430

esuwu · 2024-06-14T03:54:39Z

No description provided.

pkg/state/transaction_handler.go

pkg/state/appender.go

pkg/blockchainupdates/nuts_publisher.go

pkg/state/appender.go

nickeskov · 2024-07-16T15:28:21Z

pkg/state/accounts_data_storage.go

@@ -242,7 +242,7 @@ func (s *accountsDataStorage) entryBytes(addr proto.Address, entryKey string) ([
 func (s *accountsDataStorage) retrieveEntries(addr proto.Address) ([]proto.DataEntry, error) {
 	addrNum, err := s.addrToNum(addr)
 	if err != nil {
-		return nil, err
+		return nil, proto.ErrNotFound


err should be returned and wrapped with proto.ErrNotFound

Add check errors.Is(err, keyvalue.ErrNotFound)

Needs to be fixed

Add check errors.Is(err, keyvalue.ErrNotFound) and only then error should be wrapped

pkg/blockchaininfo/proto_converters.go

pkg/blockchaininfo/nats_publisher.go

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Return error instead of killing process with fatal log record.

Bumps [github.com/elliotchance/orderedmap/v2](https://github.com/elliotchance/orderedmap) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/elliotchance/orderedmap/releases) - [Commits](elliotchance/orderedmap@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: github.com/elliotchance/orderedmap/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Check on leasing state added. * Tests added. --------- Co-authored-by: Nikolay Eskov <[email protected]>

* Refactor and fix 'NewPeerInfoFromString' Add check for IP address parsing failure. Improved 'TestNewPeerInfoFromString'. * Improve 'NewPeerInfoFromString' Add hostname IP resolving. * Simplified 'NewTCPAddrFromString' * Refactoring and bugfix of 'resolveHostToIPv4' - Now it returns ipV4 address exactly in ipV4 form. - Fixed bug with skipping address for chesk after ipV6 removal. - Fixed bug with duplication of ipV4 address when resolving 'localhost'. * Optimized a bit 'filterToIPV4'. * Create 'NewPeerInfosFromString' function. * Use 'NewPeerInfosFromString' for resolving 'host:port' records by '-peers' CLI parameter. * Fix 'TestNewPeerInfoFromString' test. --------- Co-authored-by: Alexey Kiselev <[email protected]>

#1569) * Pulled the contract updates from snapshots, removed by block filtering * Fixed a wrong check * Removed temporary fix * Added the first block processing * Added an error handling * Fixed a linter issue

pkg/blockchaininfo/nats_publisher.go

cmd/blockchaininfo/nats_subscriber.go

pkg/blockchaininfo/nats_publisher.go

pkg/blockchaininfo/bupdates.go

…lert

nickeskov · 2025-01-15T14:43:17Z

pkg/state/state.go

+		if IsNotFound(err) {
+			return nil, err
+		}


Is it really necessary?

nickeskov · 2025-01-15T23:29:19Z

pkg/blockchaininfo/blockchaininfo_test.go

+	"github.com/wavesplatform/gowaves/pkg/proto"
+)
+
+const natsTestURL = "nats://127.0.0.1:4756"


Maybe choose a free port for testing purposes?

nickeskov · 2025-01-15T23:31:15Z

cmd/blockchaininfo/nats_subscriber.go

+func ConcatenateContractTopics(contractAddress string) string {
+	return blockchaininfo.ContractUpdates + contractAddress
+}


nickeskov · 2025-01-15T23:31:54Z

cmd/blockchaininfo/nats_subscriber.go

+		syncErr := l.Sync()
+		if syncErr != nil {
+			log.Fatalf("failed to sync zap logger %v", syncErr)
+		}


I think it's not necessary to use Fatal log level here. I suggest to use Error or Warn level here.

nickeskov · 2025-01-15T23:37:43Z

cmd/blockchaininfo/nats_subscriber.go

+			go func() {
+				if err := printContractInfo(contractUpdatesInfo, scheme, path); err != nil {
+					zap.S().Errorf("Failed to print contract info updates: %v", err)
+				}
+			}()


Why do you use goroutine here? Maybe use WaitGroup to manage goroutines resources after SIGINT receival?

nickeskov · 2025-01-16T23:25:37Z

pkg/blockchaininfo/nats_publisher.go

+		if pblshErr != nil {
+			zap.S().Errorf("failed to publish changes, %v", pblshErr)
+		}
+		bu.previousState = &updates


Updates can not replace the WHOLE previous state. As I can see updates are snapshots from the last block (after the first block is sent).
How is the whole logic work? Can you explain me, please?

nickeskov · 2025-01-16T23:53:37Z

pkg/blockchaininfo/blockchaininfo.go

+const EpochKeyPrefix = "epoch_"
+const blockMeta0xKeyPrefix = "block_0x"


Can be package private.

nickeskov · 2025-01-17T00:22:55Z

pkg/blockchaininfo/types.go

+		value, err := dataEntry.MarshalValue()
+		if err != nil {
+			return false, nil, err
+		}
+		currentMap[dataEntry.GetKey()] = value


Why do you store data entry in serialized form when you can store objects?

nickeskov · 2025-01-17T00:23:57Z

pkg/blockchaininfo/types.go

+	n, err := reader.Read(buf)
+	if err != nil {
+		return nil, err
+	}
+	if n != length {
+		return nil, errors.Errorf("expected to read %d bytes, but read %d bytes", length, n)
+	}


Should be replaced by io.ReadFull

nickeskov · 2025-01-17T00:45:03Z

pkg/blockchaininfo/blockchaininfo_test.go

Maybe add testcase with blockchain rollback scenario?

esuwu · 2025-01-17T13:58:30Z

data entries patch
mutex for extensionState
move writing into channel

esuwu added 3 commits June 13, 2024 22:54

Initial draft

63b159c

Changed a comment

69e9dbd

moved a file

b35bea1

esuwu changed the title ~~Initial draft~~ Initial design draft Jun 14, 2024

esuwu added 4 commits June 13, 2024 22:59

rename a folder

27494ad

Sent the updates channel into block appplier

983babc

Added some design comments

5272899

Context in the updates function

4fef6e3

nickeskov reviewed Jun 25, 2024

View reviewed changes

pkg/state/transaction_handler.go Outdated Show resolved Hide resolved

nickeskov reviewed Jun 25, 2024

View reviewed changes

pkg/state/appender.go Outdated Show resolved Hide resolved

nickeskov reviewed Jun 25, 2024

View reviewed changes

pkg/blockchainupdates/nuts_publisher.go Outdated Show resolved Hide resolved

nickeskov reviewed Jun 25, 2024

View reviewed changes

pkg/blockchainupdates/nuts_publisher.go Outdated Show resolved Hide resolved

esuwu added 2 commits July 1, 2024 13:27

Merge branch 'master' into node-updates-plugin-l2

dcd18f3

Added protobuf

3cc00d5

github-advanced-security bot found potential problems Jul 3, 2024

View reviewed changes

pkg/state/appender.go Fixed Show fixed Hide fixed

esuwu changed the title ~~Initial design draft~~ Blockchain updates for L2 extension Jul 3, 2024

Moved proto, added conversion

6752f8a

nickeskov reviewed Jul 16, 2024

View reviewed changes

pkg/blockchaininfo/proto_converters.go Outdated Show resolved Hide resolved

esuwu added 6 commits July 18, 2024 23:56

Added state comparison

bdc8854

Added a draft for retrieving history entries

19cc302

Renamed a function

b6fb33c

Fixed most of the linter issues

dca31ee

Merge branch 'master' into node-updates-plugin-l2

f524fe9

Added paging

18eab8c

nickeskov added wip This is a WIP, should not be merged right away do not merge The PR is not ready to be merged labels Aug 26, 2024

esuwu added 3 commits August 27, 2024 23:42

Added changes detector

e2da71e

Fixed a bug

da48829

Renamed functions

b9318c2

nickeskov requested changes Nov 14, 2024

View reviewed changes

pkg/blockchaininfo/nats_publisher.go Show resolved Hide resolved

nickeskov and others added 24 commits November 18, 2024 07:37

Merge branch 'master' into node-updates-plugin-l2

5d37195

Set 'NoSigs' option for nats sever to true.

cf23bdf

Fix 'runPublisher' in case when updates channel is closed.

d7dcd5e

Add nats sever shutdown.

d13b940

Fix deadlock and refactoring.

4dc94d5

Merge branch 'master' into node-updates-plugin-l2

214bd46

Fixed err not found handling

8fbe2b4

Fixed a toolchain not found issue (#1545)

bb23dbc

Handle blockchain import errors properly (#1548)

68db8b3

Return error instead of killing process with fatal log record.

Check on leasing state added. (#1550)

c598d67

* Check on leasing state added. * Tests added. --------- Co-authored-by: Nikolay Eskov <[email protected]>

Prepare timers for go1.23. (#1552)

bd889f5

Merge branch 'master' into node-updates-plugin-l2

6814098

Left a todo

b87f8ad

Merged from master

cdb6083

Pulled the contract updates from snapshots, removed by block filtering (

7960470

#1569) * Pulled the contract updates from snapshots, removed by block filtering * Fixed a wrong check * Removed temporary fix * Added the first block processing * Added an error handling * Fixed a linter issue

merged from master

a8fedad

Added nats requests functionality

673f800

When restarted, the previous state must be nil

a873866

Formatted a line correctly

45523aa

Merged from master

52377b4

Fixed some review issues

fb0e42f

nickeskov requested changes Jan 14, 2025

View reviewed changes

pkg/blockchaininfo/nats_publisher.go Outdated Show resolved Hide resolved

cmd/blockchaininfo/nats_subscriber.go Outdated Show resolved Hide resolved

pkg/blockchaininfo/nats_publisher.go Outdated Show resolved Hide resolved

pkg/blockchaininfo/bupdates.go Outdated Show resolved Hide resolved

esuwu added 2 commits January 15, 2025 10:16

Added an unmarshal function for blockMeta

c750bae

Write a test for a function that is not used, so the linter doesn't a…

6fd4d59

…lert

nickeskov requested changes Jan 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blockchain updates for L2 extension #1430

Blockchain updates for L2 extension #1430

esuwu commented Jun 14, 2024

nickeskov Jul 16, 2024

nickeskov Nov 7, 2024

nickeskov Nov 7, 2024

nickeskov Jan 17, 2025 •

edited

Loading

nickeskov Jan 15, 2025

nickeskov Jan 15, 2025

nickeskov Jan 15, 2025

nickeskov Jan 15, 2025

nickeskov Jan 15, 2025

nickeskov Jan 16, 2025

nickeskov Jan 16, 2025

nickeskov Jan 17, 2025

nickeskov Jan 17, 2025

nickeskov Jan 17, 2025

esuwu commented Jan 17, 2025

		const EpochKeyPrefix = "epoch_"
		const blockMeta0xKeyPrefix = "block_0x"

Blockchain updates for L2 extension #1430

Are you sure you want to change the base?

Blockchain updates for L2 extension #1430

Conversation

esuwu commented Jun 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickeskov Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

esuwu commented Jan 17, 2025

nickeskov Jan 17, 2025 •

edited

Loading