Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude flexparser 0.4 as workaround for IDAES/idaes-pse#1524 #1521

Merged

Conversation

lbianchi-lbl
Copy link
Contributor

Summary/Motivation:

Changes proposed in this PR:

  • Add requirement to exclude flexparser 0.4

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Nov 7, 2024
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving out of anticipation of checks passing

@lbianchi-lbl
Copy link
Contributor Author

Since the failure would occur when idaes get-extensions is called, and the checks are all currently past that stage, it's safe to merge this in even before the rest of the checks have completed.

@lbianchi-lbl lbianchi-lbl merged commit 532ce63 into watertap-org:main Nov 7, 2024
18 checks passed
@lbianchi-lbl lbianchi-lbl added Priority:High High Priority Issue or PR dependencies labels Nov 7, 2024
@lbianchi-lbl
Copy link
Contributor Author

This change should ideally be reverted as the issue has been fixed upstream with Pint 0.24.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants