Update BSM2-P CSTR Model #1520
Open
Update BSM2-P CSTR Model #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-a-a
reviewed
Nov 7, 2024
| @@ -537,6 +537,10 @@ def scale_variables(m): | |||
| if "conc_mass_comp" in var.name: | |||
| iscale.set_scaling_factor(var, 1e1) | |||
|
|
|||
| for unit in ("R1", "R2", "R3", "R4"): | |||
| block = getattr(m.fs, unit) | |||
| iscale.set_scaling_factor(block.hydraulic_retention_time, 1e-3) | |||
There was a problem hiding this comment.
Since we are fixing volume, does it make sense to scale this by inverse of volume/flowrate, perhaps using plant influent flowrate as a start?
There was a problem hiding this comment.
I've just tried doing this, but none of these new scaling factors work (i.e. the system fails to solve)
There was a problem hiding this comment.
what if we don't provide the scaling facotrs for the HRT as old version?
There was a problem hiding this comment.
Same thing - if we don't provide any scaling factors for HRT, the system fails to solve
adam-a-a
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
The BSM2-P flowsheet used the IDAES CSTR, but it should be using the WaterTAP CSTR, which adds a constraint for hydraulic retention time.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: