Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Allow fenv pragma to be ignored #841

Closed
wants to merge 1 commit into from
Closed

test: Allow fenv pragma to be ignored #841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/unittests/execute_floating_point_test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@
#include <array>
#include <cfenv>

#pragma GCC diagnostic push
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try clang instead of GCC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked on macOS but I guess it just ignores these.

#pragma GCC diagnostic ignored "-Wignored-pragmas"
// Enables access and modification of the floating-point environment.
// Here we use it to change rounding direction in tests.
// Although required by the C standard, neither GCC nor Clang supports it.
#pragma STDC FENV_ACCESS ON
#pragma GCC diagnostic pop

MATCHER_P(CanonicalNaN, value, "result with a canonical NaN")
{
Expand Down