Merge with upstreams #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial Overview
Includes changes for bulk memory instructions and memory abbreviations. See WebAssembly/memory64#5 and WebAssembly/memory64#6.
These are copied from the ones initially added to Binaryen
A few minor refactorings of the proposed spec rules: * Change abstract syntax of memtype to have idxtype before limits (envisioning the general structure `idxtype limits elemtype`, e.g., should we once have Table64 as well). * Parameterise syntax of limits over index syntax to accommodate tabletype. * Classify limits by index type instead of having an extra wrapper rule. * Added modified rule for memory type validation. * Factorise binary encoding for limits to make shared i64 memtypes expressible.
…y#14) * Support for the Memory64 proposal in the spec interpreter * Apply suggestions from code review Co-authored-by: Andreas Rossberg <[email protected]> * Memory64 code review fixes * Update interpreter/syntax/types.ml Co-authored-by: Andreas Rossberg <[email protected]> Co-authored-by: Andreas Rossberg <[email protected]>
This to reflect consensus reached in WebAssembly/memory64#3 See in particular WebAssembly/memory64#3 (comment)
Essentially this just allows 64-bit address operands, so kept it to just a minimal description of the instructions affected.
…4.13 (WebAssembly#1481) (WebAssembly#34) Co-authored-by: Andreas Rossberg <[email protected]>
Really we should be merging in all change from upstream but that is still in progress. Fixes: WebAssembly#35
This fixes the current CI failures.
Looks like this was missing from 76bcf86.
Split out from WebAssembly#1839
- Removed unnecessary/mismatching lookup of table/memory type in execution prose - Added missing result type lookup in formal rule for table.size and memory.size - Fixed computation of -1 result value for table.grow and table.size to work for i64 - Some fixes around specification of text format for inline elements/data shorthand - Fixed matching rules for tabletype/memtype to enforce same address type Split out from WebAssembly#1839
Interpreter: - Fixed evaluation of v128 load/store instructions to work with i64 - Reworked bulk operation execution to still reduce to well-typed instructions for i32 - Added missing size check to table allocation - Various minor refactorings and clean-ups Tests: - Added tests for size check in i64 table and memory type limits Split out from WebAssembly#1839
* Fix validation of `switch`. The validation of `switch` was not working as intended when the "switcher" and "switchee" had different continuation type immediates. The fix is to replace the current continuation from the argument list with the switched-to continuation. The previous thing happened to be working when the "switcher" and "switchee" used the same continuation type immediate. I also noticed a bug in the testsuite runner. It was not running the stack switching tests since commit WebAssembly/stack-switching@70086b9. I have added the "stack-switching" subdirectory to the test script runner such that the tests are now being run again by `make test`. Resolves WebAssembly#98. * Update interpreter/valid/valid.ml Co-authored-by: Andreas Rossberg <[email protected]> --------- Co-authored-by: Andreas Rossberg <[email protected]>
…y#1850) Specify the dry-run variable and pass it through to Echidna
…mbly#1849) Also test that the instructions trap when the offset and size overflow back to zero, with and without the segments having been dropped.
This patch brings the encoding and decoding of tag imports in sync with the exception handling proposal. Resolves WebAssembly#101.
This patch fixes problems with parsing the stack switching instructions when they appear in unfolded form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-3.0