Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CHANGELOG): generate crate changelogs #1986

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

brooksmtownsend
Copy link
Member

Feature or Problem

This PR uses cargo-changelog to generate changelogs for our crates.

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

@brooksmtownsend brooksmtownsend marked this pull request as ready for review April 25, 2024 16:31
@brooksmtownsend brooksmtownsend requested review from a team as code owners April 25, 2024 16:31
Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks reasonable -- any notes on this tool versus git-cliff the other 2893473 release management/changelog gen tools?

Want to make sure we pick something with reasonable configurability that we can run from CI -- I've used git-cliff to do that, but not cargo-changelog before.

@brooksmtownsend
Copy link
Member Author

@vados-cosmonic great question! Honestly I did it because it's the underlying tool under Byron/cargo-smart-release#17 (comment), (linked to PR where I'm adding something but the tool is cargo-smart-release) so I was hoping to keep the tools consistent since hopefully I'd be able to use that tool to release in the future! Definitely happy to consider alternatives too

@brooksmtownsend brooksmtownsend merged commit 0f03f1f into main Apr 30, 2024
52 checks passed
@brooksmtownsend brooksmtownsend deleted the feat/CHANGELOG branch April 30, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants