Skip to content

Commit

Permalink
Attempt to fix mobile spec
Browse files Browse the repository at this point in the history
  • Loading branch information
@vanpelt
vanpelt committed Jun 23, 2024
1 parent 4e0a116 commit ce9f538
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions frontend/integration_tests/basic.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ test('test good flow', async ({ page }) => {
await page.keyboard.type(
'<div class="edited">Inserted some cool text</div>\n'
)
await page.getByRole('button', { name: 'Edit HTML', exact: true }).click()
iframe = await page.frameLocator('#version-1')
await expect(iframe.locator('div.edited')).toHaveText(

Check failure on line 49 in frontend/integration_tests/basic.spec.ts

View workflow job for this annotation

GitHub Actions / test

[Mobile Safari] › basic.spec.ts:4:1 › test good flow 

  1) [Mobile Safari] › basic.spec.ts:4:1 › test good flow ──────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: frameLocator('#version-1').locator('div.edited')
    Expected string: "Inserted some cool text"
    Received: <element(s) not found>
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for frameLocator('#version-1').locator('div.edited')


      47 | 	await page.getByRole('button', { name: 'Edit HTML', exact: true }).click()
      48 | 	iframe = await page.frameLocator('#version-1')
    > 49 | 	await expect(iframe.locator('div.edited')).toHaveText(
         | 	                                           ^
      50 | 		'Inserted some cool text'
      51 | 	)
      52 | })

        at /home/runner/work/openui/openui/frontend/integration_tests/basic.spec.ts:49:45

Check failure on line 49 in frontend/integration_tests/basic.spec.ts

View workflow job for this annotation

GitHub Actions / test

[Mobile Safari] › basic.spec.ts:4:1 › test good flow 

  1) [Mobile Safari] › basic.spec.ts:4:1 › test good flow ──────────────────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: frameLocator('#version-1').locator('div.edited')
    Expected string: "Inserted some cool text"
    Received: <element(s) not found>
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for frameLocator('#version-1').locator('div.edited')


      47 | 	await page.getByRole('button', { name: 'Edit HTML', exact: true }).click()
      48 | 	iframe = await page.frameLocator('#version-1')
    > 49 | 	await expect(iframe.locator('div.edited')).toHaveText(
         | 	                                           ^
      50 | 		'Inserted some cool text'
      51 | 	)
      52 | })

        at /home/runner/work/openui/openui/frontend/integration_tests/basic.spec.ts:49:45

Check failure on line 49 in frontend/integration_tests/basic.spec.ts

View workflow job for this annotation

GitHub Actions / test

[Mobile Safari] › basic.spec.ts:4:1 › test good flow 

  1) [Mobile Safari] › basic.spec.ts:4:1 › test good flow ──────────────────────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: frameLocator('#version-1').locator('div.edited')
    Expected string: "Inserted some cool text"
    Received: <element(s) not found>
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for frameLocator('#version-1').locator('div.edited')


      47 | 	await page.getByRole('button', { name: 'Edit HTML', exact: true }).click()
      48 | 	iframe = await page.frameLocator('#version-1')
    > 49 | 	await expect(iframe.locator('div.edited')).toHaveText(
         | 	                                           ^
      50 | 		'Inserted some cool text'
      51 | 	)
      52 | })

        at /home/runner/work/openui/openui/frontend/integration_tests/basic.spec.ts:49:45
'Inserted some cool text'
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/HtmlAnnotator.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ export default function HTMLAnnotator({ error, id }: HTMLAnnotatorProps) {
<Popover open={popoverOpen}>
<PopoverTrigger asChild>
<Button
className='border-none text-muted-foreground hover:animate-wiggle-zoom hover:bg-transparent'
className='-mr-2 border-none text-muted-foreground hover:animate-wiggle-zoom hover:bg-transparent'
variant='ghost'
size='icon'
type='button'
Expand Down

0 comments on commit ce9f538

Please sign in to comment.