This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
[Bugfix] Remove index check for API objects #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raubitsj
suggested changes
Sep 1, 2020
| @@ -562,7 +562,7 @@ def _load_page(self): | |||
|
|
|||
| def __getitem__(self, index): | |||
| loaded = True | |||
| while loaded and index > len(self.objects) - 1: | |||
| while loaded: | |||
There was a problem hiding this comment.
This isnt the right fix... I think this will defeat the entire pagination system and will load everything rather than loading the page up to the index needed.
There was a problem hiding this comment.
I'm not clear on what the check is doing here.
There was a problem hiding this comment.
Looks like pagination always started at 0. And we grow the list infinitely?
There was a problem hiding this comment.
index is the element of the list we are looking for. and we keep reading pages until we get a list of items that includes that index.
at least that is how i read it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need to make this check here. Let the python stdlib make the checks on index.
This fixes the -1 issue you get on first lookup.