-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MySQL support #32
base: master
Are you sure you want to change the base?
Conversation
Looks nice. However postgres' varchar limit is 10485760. Not that this would be required. But 128 chars seems a bit restrictive. Are there any limits in mysql that would prevent - say - 2048 or even 4096 characters? |
Maximum seems to be 65535 for MySQL >5.0.3. I have to admit I didn't know how large this had to be and 128 seemed to work, I figured just specifying something really large might waste space somewhere so I guess 2048 or 4096 shouldn't be a problem. |
As is backy2 was unable to use sqlalchemy's MySQL backend. This is resolved by defining the length of strings and enable PrimaryKeyConstraint.
It's the same as postgresql because of the used backend but an example prevents some guessing.
It seems there's some other limit I'm running into, I'm getting an error [1] on initdb when using 1024, 2048 or 4096. I've updated the values to 512 and initdb works, I've created 2 backups and restored them, all seems fine. My other cluster is still using 128 since march without any (known) issues, the new cluster will be using 512 like in this pull request, unless I run into issues with this. [1] |
[s]iirc, mysql varchar limit is 255 with utf8. 767 bytes indexing[/s] never mind, i was wrong. |
I would love to see this change merged -- is there anything I can do to move it along? |
Also running with this file hand-modified in a few places. Would be good to get it merged |
Pushed a fix. Could you try again with the master branch? |
As per issue #25 these changes allow the use of MySQL as backend.