Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change default filter ping interval to 1 min #2184

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Oct 14, 2024

Problem

10 seconds as a ping interval might be an overkill and would flood ping requests from multiple clients.

Solution

Change it to 1 min

Notes

@danisharora099 danisharora099 marked this pull request as ready for review October 14, 2024 10:22
@danisharora099 danisharora099 requested a review from a team as a code owner October 14, 2024 10:22
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 85.52 KB (+0.07% 🔺) 1.8 s (+0.07% 🔺) 2.2 s (+43.54% 🔺) 3.9 s
Waku Simple Light Node 137.54 KB (+0.03% 🔺) 2.8 s (+0.03% 🔺) 2.2 s (-20.1% 🔽) 4.9 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 636 ms (+61.75% 🔺) 1.1 s
Symmetric encryption 22.37 KB (0%) 448 ms (0%) 542 ms (-20.19% 🔽) 990 ms
DNS discovery 72.9 KB (0%) 1.5 s (0%) 2.4 s (+13.31% 🔺) 3.9 s
Peer Exchange discovery 74.1 KB (0%) 1.5 s (0%) 1.2 s (-30.04% 🔽) 2.6 s
Local Peer Cache Discovery 68.03 KB (0%) 1.4 s (0%) 2.2 s (-27.93% 🔽) 3.5 s
Privacy preserving protocols 75.99 KB (0%) 1.6 s (0%) 2.3 s (+7.15% 🔺) 3.8 s
Waku Filter 79.8 KB (+0.07% 🔺) 1.6 s (+0.07% 🔺) 2.2 s (+88.78% 🔺) 3.8 s
Waku LightPush 77.77 KB (0%) 1.6 s (0%) 2.2 s (+13.46% 🔺) 3.8 s
History retrieval protocols 77.06 KB (0%) 1.6 s (0%) 1.2 s (-38.47% 🔽) 2.8 s
Deterministic Message Hashing 7.39 KB (0%) 148 ms (0%) 257 ms (-57.05% 🔽) 405 ms

@danisharora099 danisharora099 merged commit 19a5d29 into master Oct 16, 2024
11 of 12 checks passed
@danisharora099 danisharora099 deleted the chore/filter-ping-interval branch October 16, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants