-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: lighten retry logic for LightPush #2182
Conversation
size-limit report 📦
|
|
||
private readonly reliabilityMonitor: SenderReliabilityMonitor; | ||
export class LightPush implements ILightPush { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed BaseProtocolSDK
for now as it is not used
let's follow up in #2186
|
||
export interface ISender { | ||
send: ( | ||
encoder: IEncoder, | ||
message: IMessage, | ||
sendOptions?: ProtocolUseOptions | ||
sendOptions?: ISenderOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be a breaking change since ProtocolUseOptions
had a variable not in ISenderOptions
. If someone has code where that optional variable was set, will it break upon updating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true and no, ISenderOptions
actually returns previously existed properties and now they are respected in this implementation
so the only breaking change is the naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new interface doesn't have forceUseAllPeers?: boolean;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forceUseAllPeers?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot, afaik it wasn't used outside some of our tests
Problem
LightPush doesn't use
autoRetry
in current version.Solution
Add it and simplify
Notes