Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: confirm metadata and protocols needed in waitForRemotePeer #2160

Merged
merged 21 commits into from
Oct 4, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Oct 3, 2024

Problem

While we wait to confirm particular shard we should also check for enabled protocols.

Solution

Add checks.

Notes

Copy link

github-actions bot commented Oct 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 83.62 KB (0%) 1.7 s (0%) 1.3 s (-18.6% 🔽) 2.9 s
Waku Simple Light Node 135.46 KB (-0.03% 🔽) 2.8 s (-0.03% 🔽) 2.4 s (-4.32% 🔽) 5.1 s
ECIES encryption 22.94 KB (0%) 459 ms (0%) 839 ms (+69.71% 🔺) 1.3 s
Symmetric encryption 22.39 KB (0%) 448 ms (0%) 1.1 s (+23.03% 🔺) 1.5 s
DNS discovery 72.28 KB (0%) 1.5 s (0%) 1.6 s (+31.84% 🔺) 3 s
Peer Exchange discovery 73.88 KB (0%) 1.5 s (0%) 1.6 s (+42.33% 🔺) 3.1 s
Local Peer Cache Discovery 67.63 KB (0%) 1.4 s (0%) 1.3 s (+5.2% 🔺) 2.7 s
Privacy preserving protocols 74.82 KB (0%) 1.5 s (0%) 1.6 s (+56.78% 🔺) 3.1 s
Waku Filter 78.67 KB (0%) 1.6 s (0%) 1.8 s (+22.61% 🔺) 3.3 s
Waku LightPush 76.89 KB (0%) 1.6 s (0%) 1.4 s (+3.5% 🔺) 3 s
History retrieval protocols 75.97 KB (0%) 1.6 s (0%) 1.5 s (-3.59% 🔽) 3 s
Deterministic Message Hashing 7.38 KB (0%) 148 ms (0%) 564 ms (+172.11% 🔺) 712 ms

Base automatically changed from weboko/light-push to master October 4, 2024 08:51
@weboko weboko requested a review from adklempner October 4, 2024 18:21
@weboko weboko merged commit d37e024 into master Oct 4, 2024
10 of 11 checks passed
@weboko weboko deleted the weboko/improve-wait-for-remote branch October 4, 2024 23:49
@weboko weboko mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants